Fix dialect selector #391
Merged
Fix dialect selector #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanbconaway
requested review from
a team,
pwildenhain and
keraion
and removed request for
a team
greg-finley
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #389
I think there were changes introduced in sqlfluff/sqlfluff#6153 which changed the behavior of
sqlfluff.list_dialectsviadialect_readout, in which each dialect object's name became the formatted name:sqlfluff/sqlfluff@2464d36#diff-910b0d8394425a99e2c2a292887f1ac6a981341b51147a76cc7f1b79907ce933L89
This name gets passed directly to
sqlfluff.api.lint/fixfunctions, which caused errors because those functions expect labels. So the site has effectively been down for a few weeks without me noticing!This pr extends the dialects config variables such that we store a mapping of names to labels. Frontend users see only the names, which are mapped back to the label on the backend. HTTP get calls can use either the name or the label (mostly so that all the old tests continue to pass).
I added some tests that either can be used, and that the automatic dialect selector continues to work.